Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Coupling between Components #279

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Reduce Coupling between Components #279

merged 2 commits into from
Apr 15, 2024

Conversation

bryanyee33
Copy link

@bryanyee33 bryanyee33 added this to the v1.4 milestone Apr 14, 2024
Copy link

codecov bot commented Apr 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (master@0837e5c). Click here to learn what that means.

Files Patch % Lines
...dress/commons/exceptions/DataLoadingException.java 0.00% 2 Missing ⚠️
.../seedu/address/storage/JsonAddressBookStorage.java 0.00% 2 Missing ⚠️
src/main/java/seedu/address/ui/UiManager.java 0.00% 2 Missing ⚠️
src/main/java/seedu/address/ui/CommandBox.java 0.00% 1 Missing ⚠️
src/main/java/seedu/address/ui/MainWindow.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #279   +/-   ##
=========================================
  Coverage          ?   77.02%           
  Complexity        ?      513           
=========================================
  Files             ?       74           
  Lines             ?     1589           
  Branches          ?      143           
=========================================
  Hits              ?     1224           
  Misses            ?      335           
  Partials          ?       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanyee33 bryanyee33 marked this pull request as ready for review April 14, 2024 15:48
Copy link

@yisiox yisiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@aureliony aureliony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aureliony aureliony merged commit 312477e into master Apr 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StorageException is unnecessary
3 participants