Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StorageException is unnecessary #277

Closed
bryanyee33 opened this issue Apr 14, 2024 · 0 comments · Fixed by #279
Closed

StorageException is unnecessary #277

bryanyee33 opened this issue Apr 14, 2024 · 0 comments · Fixed by #279
Assignees
@bryanyee33
Labels
bug.GoodToFix A bug that is good to fix, but it's fine to not fix priority.Medium Nice to have severity.Low A flaw that is unlikely to affect normal operations of the product type.NotBug A "bug" but not really a bug
Milestone
v1.4

Comments

@bryanyee33
Copy link

StorageException is unnecessary, as the existing DataLoadingException from AB3 has the same purpose.
Moreover, it causes unnecessary dependencies such the Main component depending on Storage component.

Let's switch all used instances into DataLoadingException instead.
@bryanyee33 bryanyee33 added this to the v1.4 milestone Apr 14, 2024
@bryanyee33 bryanyee33 self-assigned this Apr 14, 2024
@bryanyee33 bryanyee33 added priority.Medium Nice to have severity.Low A flaw that is unlikely to affect normal operations of the product type.NotBug A "bug" but not really a bug bug.GoodToFix A bug that is good to fix, but it's fine to not fix labels Apr 14, 2024
This was referenced Apr 14, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bryanyee33 bryanyee33

Labels
bug.GoodToFix A bug that is good to fix, but it's fine to not fix priority.Medium Nice to have severity.Low A flaw that is unlikely to affect normal operations of the product type.NotBug A "bug" but not really a bug
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

Reduce Coupling between Components AY2324S2-CS2103T-W12-3/tp
1 participant
@bryanyee33