Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UG bugs found during PED #255

Merged
merged 48 commits into from
Apr 12, 2024
Merged

Fix UG bugs found during PED #255

merged 48 commits into from
Apr 12, 2024

Conversation

yisiox
Copy link

@yisiox yisiox commented Apr 9, 2024

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 76.94%. Comparing base (22efd1f) to head (01a60a1).

Files Patch % Lines
src/main/java/seedu/address/MainApp.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #255   +/-   ##
=========================================
  Coverage     76.94%   76.94%           
  Complexity      515      515           
=========================================
  Files            75       75           
  Lines          1596     1596           
  Branches        143      143           
=========================================
  Hits           1228     1228           
  Misses          338      338           
  Partials         30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yisiox yisiox added this to the v1.4 milestone Apr 9, 2024
@yisiox yisiox marked this pull request as ready for review April 9, 2024 18:14
@aureliony
Copy link

TODO: Write user-friendly explanation for SUBSTRING

@bryanyee33
Copy link

TODO: Write user-friendly explanation for SUBSTRING

Solved by rephrasing explanation instead.

@aureliony
Copy link

TODO: replace remaining traces of "person" with "contact"

@aureliony aureliony linked an issue Apr 12, 2024 that may be closed by this pull request
Copy link

@aureliony aureliony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@bryanyee33 bryanyee33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@fivetran-tangyetong fivetran-tangyetong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryanyee33 bryanyee33 merged commit b4ddc7a into master Apr 12, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment