Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE-D][Tester B] Phone Number parameter allows + to be entered anywhere. #200

Closed
soc-pe-bot opened this issue Apr 5, 2024 · 2 comments · Fixed by #255
Closed

[PE-D][Tester B] Phone Number parameter allows + to be entered anywhere. #200

soc-pe-bot opened this issue Apr 5, 2024 · 2 comments · Fixed by #255
Assignees
@bryanyee33
Labels
bug.GoodToFix A bug that is good to fix, but it's fine to not fix severity.Low A flaw that is unlikely to affect normal operations of the product type.DocumentationBug A flaw in the documentation
Milestone
v1.4

Comments

@soc-pe-bot
Copy link

I believe that it doesnt make sense to allow + sign to enter anywhere on the Phone Number. It is best to restrict it to the first character if utilised by the user.

image.png

Labels: type.FeatureFlaw severity.High
original: Austintjh19/ped#5
@aureliony aureliony added type.Bug A bug severity.Low A flaw that is unlikely to affect normal operations of the product labels Apr 5, 2024
@aureliony
Copy link

aureliony commented Apr 5, 2024 •
edited
Loading

This could be a bug, but it is definitely not a high severity bug.
The intention is to allow multiple phone numbers, such as +6777777, +6888888.

@aureliony aureliony added this to the v1.4 milestone Apr 6, 2024
@aureliony aureliony added bug.GoodToFix A bug that is good to fix, but it's fine to not fix type.FeatureFlaw Some functionality missing from a feature delivered in v1.4 in a way that the feature becomes less u response.NotInScope It is a valid issue but not something the team should be penalized for and removed type.Bug A bug labels Apr 8, 2024
@bryanyee33
Copy link

bryanyee33 commented Apr 10, 2024 •
edited
Loading

image

This is not considered a bug, but perhaps we could make the intention of allowing + anywhere clearer with an example.

@bryanyee33 bryanyee33 added type.NotBug A "bug" but not really a bug response.Rejected What tester treated as a bug is in fact the expected and correct behavior (from the user's point of type.DocumentationBug A flaw in the documentation and removed type.FeatureFlaw Some functionality missing from a feature delivered in v1.4 in a way that the feature becomes less u response.Rejected What tester treated as a bug is in fact the expected and correct behavior (from the user's point of type.NotBug A "bug" but not really a bug response.NotInScope It is a valid issue but not something the team should be penalized for labels Apr 10, 2024
@bryanyee33 bryanyee33 mentioned this issue Apr 10, 2024
Merged
@aureliony aureliony assigned bryanyee33 and unassigned yisiox Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bryanyee33 bryanyee33

Labels
bug.GoodToFix A bug that is good to fix, but it's fine to not fix severity.Low A flaw that is unlikely to affect normal operations of the product type.DocumentationBug A flaw in the documentation
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

Fix UG bugs found during PED AY2324S2-CS2103T-W12-3/tp
4 participants
@aureliony @bryanyee33 @soc-pe-bot @yisiox