Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes and improvements #224

Merged
merged 5 commits into from
Nov 8, 2021
Merged

Small fixes and improvements #224

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
86c9077
Fix undeleted text
cookiedan42 Nov 8, 2021
b6d023a
Add a few more manual tests
cookiedan42 Nov 8, 2021
0b4deb7
Merge branch 'master' into DG-additions
cookiedan42 Nov 8, 2021
d712736
Remove Excess spacing
cookiedan42 Nov 8, 2021
f9f280f
Fix typo
Justinhoejj Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions docs/DeveloperGuide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,12 +561,6 @@ Step 4. Since the value of `Email` (compulsory field) for the second contact is

Step 3. CONNECTIONS will not display the first contact's invalid `Tag` and will not display the second contact. The other fields and contacts will be displayed as per normal.


Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block belonged to mailingList and was left behind at the bottom here

#### Design considerations:
* Arguments for the command should follow the standard used in other parts of the software.
* Balancing between simplicity of use when no arguments are provided, and customisability for users who might want additional information.


--------------------------------------------------------------------------------------------------------------------

<div style="page-break-before: always;"></div>
Expand Down Expand Up @@ -1294,10 +1288,10 @@ testers are expected to do more *exploratory* testing.
Expected: Tags added to contact at index 1. Details of the tags added to contact are shown in the status message.

1. Test case: `tag 2 t/friends`<br>
Expected: No changes to the contact. Warning details are shown in the status message.
Expected: No changes to the contact. Warning details about existing tag(s) are shown in the status message.

1. Test case: `tag 2 t/party t/friends`<br>
Expected: New tag is added to the contact. Warning details are shown in the status message.
Expected: New tag is added to the contact. Warning details about existing tag(s) are shown in the status message.

1. Other incorrect tag commands to try: `tag`, `tag -1 t/<valid tag name>`, `tag 1 t/<tag name longer than 60 characters>`, `...`.<br>
Expected: No changes to contacts. Error details are shown in the status message.
Expand Down Expand Up @@ -1336,8 +1330,14 @@ testers are expected to do more *exploratory* testing.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space

1. Prerequisites: Filter contacts using the `find` command.

1. Test case: `mailingList` as above<br>
Expected: Same result as exporting full contact list, but with only the contacts in the filtered list
1. Test case: variations on `mailingList` as above<br>
Expected: Same result as exporting full contact list, but with only the contacts displayed in the filtered list

1. Export Empty contact list
1. Prerequisites: Filter contacts using the `find` command.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to adjust the spacing here

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah if not there will be inconsistencies in numbering.


1. Test case: `mailingList`<br>
Expected: Exporting a mailing list of 0 contacts is not allowed. Error details are shown in the status message.

### Saving data

Expand Down