Small fixes and improvements #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
=========================================
Coverage 70.75% 70.75%
Complexity 672 672
=========================================
Files 97 97
Lines 2086 2086
Branches 246 246
=========================================
Hits 1476 1476
Misses 519 519
Partials 91 91 Continue to review full report at Codecov.
|
cookiedan42
commented
Nov 8, 2021
| @@ -561,12 +561,6 @@ Step 4. Since the value of `Email` (compulsory field) for the second contact is | |||
|
|
|||
| Step 3. CONNECTIONS will not display the first contact's invalid `Tag` and will not display the second contact. The other fields and contacts will be displayed as per normal. | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
This block belonged to mailingList and was left behind at the bottom here
yucheng11122017
approved these changes
Nov 8, 2021
docs/DeveloperGuide.md
Outdated
| Expected: Same result as exporting full contact list, but with only the contacts displayed in the filtered list | ||
|
|
||
| 1. Export Empty contact list | ||
| 1. Prerequisites: Filter contacts using the `find` command. |
There was a problem hiding this comment.
Might want to adjust the spacing here
There was a problem hiding this comment.
yeah if not there will be inconsistencies in numbering.
Jiwei99
approved these changes
Nov 8, 2021
docs/DeveloperGuide.md
Outdated
| Expected: Same result as exporting full contact list, but with only the contacts displayed in the filtered list | ||
|
|
||
| 1. Export Empty contact list | ||
| 1. Prerequisites: Filter contacts using the `find` command. |
There was a problem hiding this comment.
yeah if not there will be inconsistencies in numbering.
Justinhoejj
reviewed
Nov 8, 2021
docs/DeveloperGuide.md
Outdated
| @@ -1336,8 +1330,14 @@ testers are expected to do more *exploratory* testing. | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.