Fix AddOperator() in sato test #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrabaud
approved these changes
Jul 26, 2024
wantehchang
reviewed
Jul 26, 2024
| @@ -28,7 +28,7 @@ class AvifExpression : public avifSampleTransformExpression { | |||
| token.type = AVIF_SAMPLE_TRANSFORM_INPUT_IMAGE_ITEM_INDEX; | |||
| token.inputImageItemIndex = inputImageItemIndex; | |||
| } | |||
| void AddOperator(uint8_t op) { | |||
| void AddOperator(avifSampleTransformTokenType op) { | |||
There was a problem hiding this comment.
Thank you for the pull request. I am worried that this did not fix the compiler warning. (Compiler warnings are not enabled on tests yet. Sorry about the confusion.) I will test this using a draft pull request of mine later (#2318).
The warning we need to fix is:
warning C4244: 'argument': conversion from 'const avifSampleTransformTokenType' to 'uint8_t', possible loss of data
Since token.type is a uint8_t, the assignment token.type = op; is now a conversion from 'const avifSampleTransformTokenType' to 'uint8_t', so I am worried that MSVC will warn about the assignment.
There was a problem hiding this comment.
Sorry, it was an oversight on my end. Fixed in #2331.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2322.