Compile avif_apps_internal without -DAVIF_DLL #2318
Merged
+28
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7e82740 to
c38f940
Compare
39f17d7 to
11d0965
Compare
In shared library builds (-DBUILD_SHARED_LIBS=ON), compile the source files in the avif_apps_internal static library without -DAVIF_DLL. Also link avif_obj with the m and Threads::Threads libraries in the PRIVATE scope instead of the PUBLIC scope. Fix AOMediaCodec#2339.
11d0965 to
e7169b3
Compare
|
@vrabaud FYI. |
jzern
approved these changes
Jul 31, 2024
| macro(add_avif_apps_library suffix) | ||
| add_library(avif_apps${suffix} STATIC ${AVIF_APPS_SRCS}) | ||
| target_link_libraries(avif_apps${suffix} PUBLIC avif${suffix} PRIVATE PNG::PNG ZLIB::ZLIB JPEG::JPEG avif_enable_warnings) | ||
| if(CMAKE_SYSTEM_NAME STREQUAL "Linux") |
There was a problem hiding this comment.
Is this generic enough? I'm wondering if BSD variants would need this too.
There was a problem hiding this comment.
In line 454 we use the condition if(UNIX OR MINGW) for linking with libm and Threads::Threads.
In libaom we check the condition if(NOT WIN32 AND NOT APPLE) for linking with libm.
I also found a Stack Overflow article on this issue:
https://stackoverflow.com/questions/34625627/how-to-link-to-the-c-math-library-with-cmake
There was a problem hiding this comment.
Maybe the find_library method might be the safest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In shared library builds (-DBUILD_SHARED_LIBS=ON), compile the source
files in the avif_apps_internal static library without -DAVIF_DLL.
Also link avif_obj with the m and Threads::Threads libraries in the
PRIVATE scope instead of the PUBLIC scope.
Fix #2339.