Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grid_map_core: Use ament_export_targets and improve eigen linkage (backport #404) #434

Merged
merged 2 commits into from
Feb 16, 2024
Merged

grid_map_core: Use ament_export_targets and improve eigen linkage (backport #404) #434

merged 2 commits into from
Feb 16, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 16, 2024

This is an automatic backport of pull request #404 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Ryanf55 and others added 2 commits February 16, 2024 05:19
@Ryanf55 @mergify
Update ament to latest recommendations
5f80371 
* Fixes include errors in grid_map_geo ros2 port

Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
(cherry picked from commit 4f32682)
@wep21 @mergify
fix: use target link libraries instead of ament target deps
712be2b 
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
(cherry picked from commit 89ead03)
@mergify mergify bot mentioned this pull request Feb 16, 2024
Merged
@Ryanf55 Ryanf55 merged commit 6625e1f into humble Feb 16, 2024
1 check passed
@Ryanf55 Ryanf55 deleted the mergify/bp/humble/pr-404 branch February 16, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ryanf55 @wep21