grid_map_core: Use ament_export_targets and improve eigen linkage #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
wep21
reviewed
Feb 3, 2024
* Fixes include errors in grid_map_geo ros2 port Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
d2bfed2 to
89ead03
Compare
|
@Ryanf55 This PR includes some commits for rolling. Is it better to change the target branch to rolling? |
Ah yes, I've changed the target branch. |
|
@Mergifyio backport iron |
✅ Backports have been created
|
Ryanf55
added a commit
that referenced
this pull request
Feb 16, 2024
grid_map_core: Use ament_export_targets and improve eigen linkage (backport #404)
|
@Mergifyio backport humble |
✅ Backports have been created
|
Ryanf55
added a commit
that referenced
this pull request
Feb 16, 2024
grid_map_core: Use ament_export_targets and improve eigen linkage (backport #404)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes include errors in grid_map_geo ros2 port. If you need, I can rebase and target to rolling first.
Relates to #403, but to close that issue out, these changes should ideally be reflected across the whole repo.