Disable m_aos for SoA Particle #3736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the type of m_aos for SoA particle to void*. Because void* cannot be dereferenced, this can avoid bugs that use m_aos on SoA particles.
ax3l
reviewed
Jan 31, 2024
| @@ -18,9 +18,12 @@ auto call_f (F const& f, | |||
| GpuArray<Real,AMREX_SPACEDIM> const& plo, | |||
| GpuArray<Real,AMREX_SPACEDIM> const& dxi) noexcept | |||
| { | |||
| if constexpr (IsCallable<F, decltype(p.m_aos[i]), decltype(fabarr), decltype(plo), decltype(dxi)>::value) { | |||
| using PTDTypeT = std::remove_const_t<std::remove_reference_t<decltype(p)>>; | |||
There was a problem hiding this comment.
Let's add #include <type_traits> to this file for robustness :)
There was a problem hiding this comment.
isen't PTDTypeT the same as PTDType<T_ParticleType, NAR, NAI>?
There was a problem hiding this comment.
Right. Maybe it's silly to do it like this, but I just didn't want to introduce typos.
ax3l
approved these changes
Jan 31, 2024
WeiqunZhang
pushed a commit
that referenced
this pull request
Jan 31, 2024
## Summary Move into type to mitigate MSVC compile errors: ``` Src\Particle\AMReX_ParticleTile.H(48,5): error C2219: syntax error: type qualifier must be after '*' ``` ## Additional background Follow-up to #3736. Seen in ECP-WarpX/WarpX#4654 ## Checklist The proposed changes: - [x] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the type of m_aos for SoA particle to void*. Because void* cannot be dereferenced, this can avoid bugs that use m_aos on SoA particles.