Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug with HDF5 boxcenter data #1213

Merged
merged 11 commits into from
Jul 29, 2020
Merged

Fix a bug with HDF5 boxcenter data #1213

merged 11 commits into from
Jul 29, 2020

Conversation

houjun
Copy link
Contributor

@houjun houjun commented Jul 28, 2020

Summary

Fixes #1212 with wrong HDF5 centering vector (boxcenter dataset) value assignment

Additional background

Checklist

The proposed changes:

  • [x ] fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • are described in the proposed changes to the AMReX documentation, if appropriate

@atmyers atmyers self-requested a review July 29, 2020 00:11
@atmyers
Copy link
Member

atmyers commented Jul 29, 2020

Thank you!

@atmyers atmyers merged commit 94961ad into AMReX-Codes:development Jul 29, 2020
dwillcox pushed a commit to dwillcox/amrex that referenced this pull request Oct 3, 2020
* Fix a bug that causes wrong value assignment for the boxcenter dataset

Co-authored-by: Houjun Tang <htang4@lbl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HDF5 I/O - format details and possible typo in node vs cell data
2 participants