Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.3.0 #3394

Merged
merged 268 commits into from
Apr 6, 2023
Merged

Release v1.3.0 #3394

merged 268 commits into from
Apr 6, 2023

Conversation

jason-aelf
Copy link
Collaborator

closes #3393

@vizipi
Copy link

vizipi bot commented Apr 6, 2023

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
91.00 % EanCuznaivy 775 192
63.03 % ZhangXin 192 133
58.77 % gldeng 108 124
58.29 % weili 342 123
55.92 % swk 451 118
52.13 % Peng Rong 69 110

Potential missing files from this Pull request

No commonly committed files found with a 40% threashold


Committed file ranks

(click to expand)
  • 79.05%[src/AElf.Kernel.CodeCheck/AElf.Kernel.CodeCheck.csproj]
  • 88.16%[...contract/AElf.Contracts.MultiToken/TokenContract_Delegati]
  • 93.06%[protobuf/test_basic_function_contract.proto]
  • 98.62%[...test/AElf.Contracts.MultiToken.Tests/BVT/TokenManagementT]
  • 90.03%[test/AElf.Contracts.TestContract.DApp/DAppContract.cs]
  • 83.68%[...test/AElf.Contracts.Economic.TestBase/EconomicTestTransac]
  • 82.33%[...src/AElf.Kernel.SmartContract.ExecutionPluginForCallThres]
  • 76.82%[...src/AElf.Kernel.CodeCheck/Application/CodeCheckProposalSe]
  • 50.31%[test/AElf.CSharp.CodeOps.UnitTests/Extensions.cs]
  • 97.54%[protobuf/treasury_contract.proto]
  • @vizipi vizipi bot requested review from zhxymh, gldeng, shiwk and rosona April 6, 2023 02:36
    @codecov
    Copy link

    codecov bot commented Apr 6, 2023

    Codecov Report

    Merging #3394 (7b06a33) into master (8d733b0) will decrease coverage by 0.10%.
    The diff coverage is 84.67%.

    Additional details and impacted files

    Impacted file tree graph

    @@            Coverage Diff             @@
    ##           master    #3394      +/-   ##
    ==========================================
    - Coverage   91.01%   90.91%   -0.10%     
    ==========================================
      Files         619      640      +21     
      Lines       23684    24007     +323     
      Branches     2094     2104      +10     
    ==========================================
    + Hits        21557    21827     +270     
    - Misses       1996     2075      +79     
    + Partials      131      105      -26     
    Impacted Files Coverage Δ
    ...s/Instructions/IStateWrittenInstructionInjector.cs 94.11% <0.00%> (-2.86%) ⬇️
    ...harp.CodeOps/Patchers/Module/MethodCallReplacer.cs 0.00% <0.00%> (-98.42%) ⬇️
    ...deOps/Validators/Assembly/SingleModuleValidator.cs 0.00% <0.00%> (ø)
    ...f.Kernel.CodeCheck/Application/CodeCheckService.cs 100.00% <ø> (ø)
    ...nForCallThreshold/CheckThresholdExecutionPlugin.cs 100.00% <ø> (ø)
    ...ourceFee/ResourceConsumptionPostExecutionPlugin.cs 100.00% <ø> (ø)
    ...sourceFee/ResourceConsumptionPreExecutionPlugin.cs 100.00% <ø> (ø)
    ...martContract.Shared/ISmartContractBridgeContext.cs 75.00% <ø> (ø)
    ...ontract/Application/ISmartContractBridgeService.cs 100.00% <ø> (ø)
    ...ct/Application/SmartContractExecutionPluginBase.cs 100.00% <ø> (ø)
    ... and 52 more

    ... and 23 files with indirect coverage changes

    @jason-aelf jason-aelf merged commit b4df4f6 into master Apr 6, 2023
    @chopin-fan chopin-fan deleted the release/1.3.0 branch August 19, 2024 06:31
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.