Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code check failure in parallel #3384

Merged
merged 15 commits into from
Mar 29, 2023
Merged

Conversation

zhxymh
Copy link
Collaborator

@zhxymh zhxymh commented Mar 16, 2023

Closes #3386

@vizipi
Copy link

vizipi bot commented Mar 16, 2023

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
73.91 % EanCuznaivy 77 17
60.87 % jason-hoopox 38 14
47.83 % weili 31 11
39.13 % swk 105 9
39.13 % xiangxingxing 46 9
39.13 % Peng Rong 8 9

Potential missing files from this Pull request

No commonly committed files found with a 40% threashold


Committed file ranks

(click to expand)
  • 70.57%[...test/AElf.Kernel.CodeCheck.Tests/Application/CodeCheckJob]
  • 56.87%[...src/AElf.Kernel.CodeCheck/Application/CodeCheckJobProcess]
  • 83.67%[src/AElf.Kernel.CodeCheck/CodeCheckAElfModule.cs]
  • 95.16%[...contract/AElf.Contracts.Genesis/BasicContractZeroContract]
  • 86.62%[...test/AElf.Kernel.CodeCheck.Tests/AElf.Kernel.CodeCheck.Te]
  • 90.03%[...src/AElf.Kernel.CodeCheck/CodeCheckRequiredLogEventProces]
  • 40.12%[src/AElf.Kernel.CodeCheck/CodeCheckOptions.cs]
  • 40.12%[test/AElf.Kernel.CodeCheck.Tests/CodeCheckTestBase.cs]
  • 0.00%[...test/AElf.Kernel.CodeCheck.Tests/CodeCheckParallelTestAEl]
  • 20.41%[test/AElf.Kernel.CodeCheck.Tests/MockContractPatcher.cs]
  • @vizipi vizipi bot requested review from jason-aelf, shiwk and ssun0121 March 16, 2023 10:54
    @codecov
    Copy link

    codecov bot commented Mar 16, 2023

    Codecov Report

    Merging #3384 (36b9af5) into release/1.3.0 (a697652) will increase coverage by 0.07%.
    The diff coverage is 79.45%.

    Additional details and impacted files

    Impacted file tree graph

    @@                Coverage Diff                @@
    ##           release/1.3.0    #3384      +/-   ##
    =================================================
    + Coverage          91.44%   91.52%   +0.07%     
    =================================================
      Files                633      634       +1     
      Lines              23673    23671       -2     
      Branches            2066     2065       -1     
    =================================================
    + Hits               21648    21664      +16     
    + Misses              1920     1902      -18     
      Partials             105      105              
    Impacted Files Coverage Δ
    ...ontractZeroContract_ACS1_TransactionFeeProvider.cs 83.67% <20.00%> (-16.33%) ⬇️
    ...ntract/AElf.Contracts.Genesis/BasicContractZero.cs 84.33% <60.00%> (ø)
    ...nel.CodeCheck/Application/CodeCheckJobProcessor.cs 88.88% <88.88%> (ø)
    ...AElf.Contracts.Genesis/BasicContractZero_Helper.cs 97.80% <100.00%> (+0.03%) ⬆️
    src/AElf.Kernel.CodeCheck/CodeCheckAElfModule.cs 100.00% <100.00%> (ø)
    src/AElf.Kernel.CodeCheck/CodeCheckOptions.cs 100.00% <100.00%> (ø)
    ...el.CodeCheck/CodeCheckRequiredLogEventProcessor.cs 93.33% <100.00%> (-5.11%) ⬇️

    ... and 3 files with indirect coverage changes

    @vizipi vizipi bot requested a review from rosona March 21, 2023 06:16
    @zhxymh zhxymh changed the title [WIP] Fix block validation failure due to code checking exception [WIP] Fix code check failure in parallel Mar 23, 2023
    @zhxymh zhxymh changed the title [WIP] Fix code check failure in parallel Fix code check failure in parallel Mar 29, 2023
    @vizipi vizipi bot requested a review from jason-aelf March 29, 2023 02:00
    @jason-aelf jason-aelf merged commit a23fa62 into release/1.3.0 Mar 29, 2023
    @delete-merged-branch delete-merged-branch bot deleted the fix/code-check-exception branch March 29, 2023 07:58
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants