Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONTRIBUTING.md for PR Process #9

Merged
merged 11 commits into from
Nov 26, 2024
Merged

CONTRIBUTING.md for PR Process #9

merged 11 commits into from
Nov 26, 2024

Conversation

CodeGat
Copy link
Member

@CodeGat CodeGat commented Nov 18, 2024

In this PR:

  • Create a CONTRIBUTING.md file that explains the PR process that is enabled by build-cd.

Feedback is appreciated, and I'm happy for others to edit this PR.

Closes ACCESS-NRI/build-cd#163

@CodeGat CodeGat self-assigned this Nov 18, 2024
harshula
harshula reviewed Nov 18, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
harshula
harshula reviewed Nov 18, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
harshula
harshula reviewed Nov 18, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
harshula
harshula reviewed Nov 18, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CodeGat and others added 2 commits November 18, 2024 13:59
@CodeGat
Update Header
ba6dd8d
@CodeGat @harshula
Apply suggestions from code review
7dbf7d1 
Co-authored-by: Harshula Jayasuriya <harshula.jayasuriya@anu.edu.au>
harshula
harshula reviewed Nov 18, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
aidanheerdegen
aidanheerdegen reviewed Nov 21, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
aidanheerdegen
aidanheerdegen reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some suggestions.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
harshula
harshula reviewed Nov 21, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
harshula
harshula reviewed Nov 21, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CodeGat and others added 2 commits November 22, 2024 13:54
@CodeGat @harshula @aidanheerdegen
Apply suggestions from code review
963ca95 
Co-authored-by: Harshula Jayasuriya <harshula.jayasuriya@anu.edu.au>
Co-authored-by: Aidan Heerdegen <aidan.heerdegen@gmail.com>
@CodeGat
Remove references to 'we', move modifications of config to a note
8bc3cf1
@CodeGat CodeGat marked this pull request as ready for review November 22, 2024 03:24
harshula
harshula reviewed Nov 22, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
harshula
harshula reviewed Nov 22, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
harshula
harshula reviewed Nov 22, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
harshula
harshula reviewed Nov 22, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
harshula
harshula reviewed Nov 22, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
harshula
harshula reviewed Nov 22, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
harshula
harshula reviewed Nov 22, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
harshula
harshula requested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@harshula harshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good. A few small changes.

@CodeGat @harshula
Apply suggestions from code review
10ee353 
Co-authored-by: Harshula Jayasuriya <harshula.jayasuriya@anu.edu.au>
@CodeGat CodeGat requested a review from harshula November 22, 2024 06:00
aidanheerdegen
aidanheerdegen reviewed Nov 25, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@CodeGat CodeGat mentioned this pull request Nov 25, 2024
Merged
aidanheerdegen
aidanheerdegen reviewed Nov 25, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@CodeGat @aidanheerdegen
Update CONTRIBUTING.md
7474590 
Co-authored-by: Aidan Heerdegen <aidan.heerdegen@gmail.com>
aidanheerdegen
aidanheerdegen approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeGat CodeGat merged commit 80117aa into main Nov 26, 2024
@CodeGat CodeGat deleted the build-cd-163-pr-doc branch November 26, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidanheerdegen aidanheerdegen aidanheerdegen approved these changes

@harshula harshula harshula approved these changes

Assignees

@CodeGat CodeGat

Labels
priority:high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hive-Docs document required on how to use the Pre-Release deployment functionality
3 participants
@CodeGat @harshula @aidanheerdegen