-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add !redeploy
Comment Command
#176
Conversation
Note, this will have to be reworked as we are hitting the limit of 5 nested workflow calls. |
…b.*` contexts with `inputs.pr`/`needs.default.outputs.*`
9ce2d34
to
f23691e
Compare
930d477
to
e7c35fa
Compare
This stops the `workflow_call` limitation mentioned in the PR
Removed ci-comment pr inputs
e7c35fa
to
8b26634
Compare
@CodeGat Will this be used on public repos? If so, would it be an issue with anyone being able to add the magic comment to PRs? |
Good point @tmcadam - I'll add a similar step that checks the permissions of the user. |
@CodeGat Could this also be achieved with |
Indeed, it's for the branch of the action. And I think it's less overhead to do a command in the PR rather than a workflow dispatch where they need to remember the PR number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Even though this has added a lot of code, the refactor makes it much cleaner I think.
I also appreciated the very thorough overview in the top level post. The context helped a lot with understanding what was being done, which made it a lot quicker for me to review.
Background
See ACCESS-NRI/model-deployment-template#9 (comment) - instructions for people to add empty commits to redeploy their model is a bit fiddly. So, create a ChatOps command to redeploy, instead.
The majority of this PR is updating the
ci.yml
job to handle an explicitinputs.pr
rather than inferring fromgithub.event.pull_request
/github.[head|base]_ref
, since we now offer two entrypoints intoci.yml
-on.pull_request
, andon.issue_comment
(specifically, commenting!redeploy
).We also have
redeploy-pre
/redeploy-post
jobs added when the trigger is a!redeploy
comment, in which we set the HEAD commit status to pending, run the rest of theci.yml
, then update the HEAD commit again based on the prerelease deployment status.In this PR:
ci.yml
spack
Environment Name Not Filled In #146pr
, set pr metadata indefaults
and clone all repos atinputs.pr
, replace allgithub.*
contexts withinputs.pr
/needs.default.outputs.*
redeploy-pre
andredeploy-post
jobs that handle commit status updates on!redeploy
validate-repo-version
action: Added new required inputpr
, updated references inci.yml
Requirements for Model Deployment Repositories
Before merge, there must be updates to deployment repositories like so:
Testing
!redeploy
Comment Command ACCESS-TEST#7 - note the successes at the end!gh
commands were tested locallyCloses #173
Closes #146