Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 Compat #284

Closed
wants to merge 3 commits into from
Closed

PHP 8.1 Compat #284

wants to merge 3 commits into from

Conversation

turtlepod
Copy link
Member

Tested in PHP 8.1:
"PHP message: PHP Deprecated: Automatic conversion of false to array is deprecated in /var/www/wp-content/plugins/restricted-site-access/restricted_site_access.php on line 319"

Description of the Change

Simple change to make sure $options var is array and not produce warning in PHP 8.1+

Closes #

How to test the Change

Test in PHP 8.1+ and simply check the error log

Changelog Entry

Fixed: PHP 8.1 compat for get_options()

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

@turtlepod

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Tested in PHP 8.1:
"PHP message: PHP Deprecated:  Automatic conversion of false to array is deprecated in /var/www/wp-content/plugins/restricted-site-access/restricted_site_access.php on line 319"
@turtlepod turtlepod requested a review from Sidsector9 as a code owner October 24, 2023 05:56
@github-actions github-actions bot added this to the 7.4.1 milestone Oct 24, 2023
@github-actions github-actions bot added the needs:code-review This requires code review. label Oct 24, 2023
@Sidsector9
Copy link
Member

Thanks for the PR @turtlepod. A PR was already raised, so I will close this PR in favour of #281.

@Sidsector9 Sidsector9 closed this Oct 25, 2023
@jeffpaul jeffpaul deleted the fix/php-81-compat branch July 5, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants