Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix autovivification on false #281

Merged
merged 4 commits into from
Oct 25, 2023
Merged

chore: fix autovivification on false #281

merged 4 commits into from
Oct 25, 2023

Conversation

mae829
Copy link
Contributor

@mae829 mae829 commented Oct 10, 2023

Description of the Change

Fixes the autovivification issue referenced in the issue.

Although it currently only throws a warning when running PHP 8.1 and won't throw a fatal error until PHP 9.0, this could build up in logs.

Closes #280

How to test the Change

  1. Install plugin on fresh WP install running on PHP 8.1
  2. Check user FE.
  3. Check logs (or Query Monitor) for deprecated notice PHP Deprecated: Automatic conversion of false to array is deprecated.

Changelog Entry

Fixed - Prep for PHP 8.1 deprecated autovivification on false.

Credits

Props @mae829

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@mae829 mae829 requested a review from Sidsector9 as a code owner October 10, 2023 00:01
@jeffpaul jeffpaul added this to the 7.4.1 milestone Oct 10, 2023
Copy link
Member

@Sidsector9 Sidsector9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, tests well 👍

@Sidsector9 Sidsector9 merged commit 01821ca into 10up:develop Oct 25, 2023
@Sidsector9 Sidsector9 mentioned this pull request Oct 25, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.1 autovivification on false
3 participants