Skip to content

Commit

Permalink
Merge pull request kubewharf#83 from cheney-lin/dev/shared_cores_over…
Browse files Browse the repository at this point in the history
…lap_reclaimed_cores

feat: support shared_cores overlap reclaimed_cores
  • Loading branch information
waynepeking348 authored May 8, 2024
2 parents 1a0977f + 9309fdf commit 0f4045c
Show file tree
Hide file tree
Showing 3 changed files with 44 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,15 @@ spec:
properties:
advisorConfig:
properties:
cpuAdvisorConfig:
properties:
allowSharedCoresOverlapReclaimedCores:
description: AllowSharedCoresOverlapReclaimedCores is
a flag, when enabled, we will rely on kernel features
to ensure that shared_cores pods can suppress and preempt
reclaimed_cores pods.
type: boolean
type: object
memoryAdvisorConfig:
properties:
memoryGuardConfig:
Expand Down
9 changes: 9 additions & 0 deletions pkg/apis/config/v1alpha1/adminqos.go
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,19 @@ type MemoryHeadroomConfig struct {
}

type AdvisorConfig struct {
// +optional
CPUAdvisorConfig *CPUAdvisorConfig `json:"cpuAdvisorConfig,omitempty"`
// +optional
MemoryAdvisorConfig *MemoryAdvisorConfig `json:"memoryAdvisorConfig,omitempty"`
}

type CPUAdvisorConfig struct {
// AllowSharedCoresOverlapReclaimedCores is a flag, when enabled,
// we will rely on kernel features to ensure that shared_cores pods can suppress and preempt reclaimed_cores pods.
// +optional
AllowSharedCoresOverlapReclaimedCores *bool `json:"allowSharedCoresOverlapReclaimedCores,omitempty"`
}

type MemoryAdvisorConfig struct {
// MemoryGuardConfig is a config for memory guard plugin, which is used to avoid high priority workload from being
// affected by memory bursting caused by low priority workload.
Expand Down
26 changes: 26 additions & 0 deletions pkg/apis/config/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 0f4045c

Please sign in to comment.