Merge pull request #541 from 3bdNKocY/3bdNKocY-patch-1

Avoid creating new strings when parsing PcData
zzzprojects · Mar 27, 2024 · d1574ef · d1574ef
2 parents 2806ec5 + 7703d81
commit d1574ef
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/src/HtmlAgilityPack.Shared/HtmlDocument.cs b/src/HtmlAgilityPack.Shared/HtmlDocument.cs
@@ -1741,8 +1741,16 @@ private void Parse()
                         // check buffer end
                         if ((_currentnode._namelength + 3) <= (Text.Length - (_index - 1)))
                         {
-                            if (string.Compare(Text.Substring(_index - 1, _currentnode._namelength + 2),
-                                    "</" + _currentnode.Name, StringComparison.OrdinalIgnoreCase) == 0)
+                            var tagStartMatching = Text[_index - 1] == '<' && Text[_index] == '/';
+                            var tagMatching = string.Compare(
+                                    Text,
+                                    _index + 1,
+                                    _currentnode.Name,
+                                    0,
+                                    _currentnode._namelength,
+                                    StringComparison.OrdinalIgnoreCase)
+                                == 0;
+                            if (tagStartMatching && tagMatching)
                             {
                                 int c = Text[_index - 1 + 2 + _currentnode.Name.Length];
                                 if ((c == '>') || (IsWhiteSpace(c)))