Bump zwave-js to 11.5.3 and schema to 30 #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCalzone
reviewed
Jul 24, 2023
Comment on lines
+643
to
+644
| const node30 = node14 as Partial<NodeStateSchema30>; | ||
| node30.lastSeen = node.lastSeen; |
There was a problem hiding this comment.
Are you using the as Partial to stop TS from complaining that lastSeen is missing?
I would probably do this instead:
const node30: NodeStateSchema30 = {
...node14,
lastSeen: node.lastSeen
}There was a problem hiding this comment.
that's fair, but can we stick with the original pattern for this PR and work on a better one in a separate PR?
AlCalzone
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds lastSeen property to node dump and cleans up some code