WIP: Rename 'getAllUsersByEmail' to 'getUsersAndBotsByEmail' and type it #3332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not use the existing `getAllUsersByEmail` since it returns all users and realm bots and messes up our strict typing. (That selector can and should be renamed and typed better later)
The previous iteration of `PresenceStatusIndicator` used a single user's `presence` entry to determine what to render. That was not clearly better than having this component extract the data on its own from the state. Now though, we need to also have the `userStatus` data and manually passing this becomes too much boilerplate. This change only replaces our use of pre-extracted `presence` data with getting an `email` of a user instead and doing the extraction inside the component. A lot of container components did change, but the change is straightforward, covered by tests and simplifies our code. Removed `exraData` prop in `UserList` as not needed (and misspelled)
Now `connect`s to the `userStatus` state and if `away` for the given user exists and is set to `true`, we override the calculated value and make it `offline` instead. It is unfortunate that there is a (temporary) discrepancy between our `presence` and `userStatus` key used for mapping (`email` vs `user_id`) thus needing the `usersByEmail` state too. We should be moving `presence` to 'id to presence mapping' and then we would replace the `email` prop with `userId` prop. Later.
Renames 'getAllUsersByEmail' to better reflect the data it returns. Also, add Flow types to the selector.
|
Thanks @borisyankov ! Did you look at the history of this file? I mentioned in #3326 (comment) that there is some relevant background there: We can certainly change things, but the commit that makes the change has to point to the previous discussion and explain why we're doing something different. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wonder what would be the most practical way to handle the:
Cannot get user.avatar_url because property avatar_url is missing in RealmBot [1].