Skip to content

Commit

Permalink
autocomplete [nfc]: Explain why no [AutocompleteViewManager.dispose]
Browse files Browse the repository at this point in the history
  • Loading branch information
gnprice committed May 7, 2024
1 parent d882f50 commit ebf41f2
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions lib/model/autocomplete.dart
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,13 @@ class AutocompleteViewManager {
view.reassemble();
}
}

// No `dispose` method, because there's nothing for it to do.
// The [MentionAutocompleteView]s are owned by (i.e., they get [dispose]d by)
// the UI code that manages the autocomplete interaction, including in the
// case where the [PerAccountStore] is replaced. Discussion:
// https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/.60MentionAutocompleteView.2Edispose.60/near/1791292
// void dispose() { … }
}

/// A view-model for a mention-autocomplete interaction.
Expand Down

0 comments on commit ebf41f2

Please sign in to comment.