Skip to content

Commit

Permalink
l10n [nfc]: Rename localized string to recentDmConversationsButton
Browse files Browse the repository at this point in the history
The page it used to represent no longer exists.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
  • Loading branch information
PIG208 committed Dec 3, 2024
1 parent 2f235b8 commit 15503a5
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions assets/l10n/app_en.arb
Original file line number Diff line number Diff line change
Expand Up @@ -533,9 +533,9 @@
"@inboxButton": {
"description": "Label for the menu button switching to inbox."
},
"recentDmConversationsPageTitle": "Direct messages",
"@recentDmConversationsPageTitle": {
"description": "Title for the page of recent DM conversations"
"recentDmConversationsButton": "Direct messages",
"@recentDmConversationsButton": {
"description": "Label for the menu button switching to recent DM conversations."
},
"combinedFeedPageTitle": "Combined feed",
"@combinedFeedPageTitle": {
Expand Down
4 changes: 2 additions & 2 deletions lib/generated/l10n/zulip_localizations.dart
Original file line number Diff line number Diff line change
Expand Up @@ -805,11 +805,11 @@ abstract class ZulipLocalizations {
/// **'Inbox'**
String get inboxButton;

/// Title for the page of recent DM conversations
/// Label for the menu button switching to recent DM conversations.
///
/// In en, this message translates to:
/// **'Direct messages'**
String get recentDmConversationsPageTitle;
String get recentDmConversationsButton;

/// Title for the page of combined feed.
///
Expand Down
2 changes: 1 addition & 1 deletion lib/generated/l10n/zulip_localizations_ar.dart
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
String get inboxButton => 'Inbox';

@override
String get recentDmConversationsPageTitle => 'Direct messages';
String get recentDmConversationsButton => 'Direct messages';

@override
String get combinedFeedPageTitle => 'Combined feed';
Expand Down
2 changes: 1 addition & 1 deletion lib/generated/l10n/zulip_localizations_en.dart
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
String get inboxButton => 'Inbox';

@override
String get recentDmConversationsPageTitle => 'Direct messages';
String get recentDmConversationsButton => 'Direct messages';

@override
String get combinedFeedPageTitle => 'Combined feed';
Expand Down
2 changes: 1 addition & 1 deletion lib/generated/l10n/zulip_localizations_ja.dart
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
String get inboxButton => 'Inbox';

@override
String get recentDmConversationsPageTitle => 'Direct messages';
String get recentDmConversationsButton => 'Direct messages';

@override
String get combinedFeedPageTitle => 'Combined feed';
Expand Down
2 changes: 1 addition & 1 deletion lib/widgets/home.dart
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ class _DirectMessagesButton extends _NavigationBarMenuButton {

@override
String label(ZulipLocalizations zulipLocalizations) {
return zulipLocalizations.recentDmConversationsPageTitle;
return zulipLocalizations.recentDmConversationsButton;
}

@override
Expand Down

0 comments on commit 15503a5

Please sign in to comment.