Merge pull request #228 from excalidraw/master

fix: only bind arrow (excalidraw#8152)
zsviczian · Jun 19, 2024 · 7fafa1f · 7fafa1f
2 parents 36e266e + a1ffa06
commit 7fafa1f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/packages/excalidraw/data/restore.ts b/packages/excalidraw/data/restore.ts
@@ -23,6 +23,7 @@ import {
   refreshTextDimensions,
 } from "../element";
 import {
+  isArrowElement,
   isLinearElement,
   isTextElement,
   isUsingAdaptiveRadius,
@@ -474,13 +475,15 @@ export const restoreElements = (
     if (isLinearElement(element)) {
       if (
         element.startBinding &&
-        !restoredElementsMap.has(element.startBinding.elementId)
+        (!restoredElementsMap.has(element.startBinding.elementId) ||
+          !isArrowElement(element))
       ) {
         (element as Mutable<ExcalidrawLinearElement>).startBinding = null;
       }
       if (
         element.endBinding &&
-        !restoredElementsMap.has(element.endBinding.elementId)
+        (!restoredElementsMap.has(element.endBinding.elementId) ||
+          !isArrowElement(element))
       ) {
         (element as Mutable<ExcalidrawLinearElement>).endBinding = null;
       }

diff --git a/packages/excalidraw/element/binding.ts b/packages/excalidraw/element/binding.ts
@@ -360,6 +360,9 @@ export const bindLinearElement = (
   startOrEnd: "start" | "end",
   elementsMap: NonDeletedSceneElementsMap,
 ): void => {
+  if (!isArrowElement(linearElement)) {
+    return;
+  }
   mutateElement(linearElement, {
     [startOrEnd === "start" ? "startBinding" : "endBinding"]: {
       elementId: hoveredElement.id,