Skip to content

Commit

Permalink
fix: update attributes and add integration tests
Browse files Browse the repository at this point in the history 
Changed rules.names attribute within app protection custom control resource to optional.

Added zpa-test.yml for daily integration test execution.
  • Loading branch information
@willguibr
willguibr committed Apr 25, 2024
1 parent 70cfb47 commit 0dcca50
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 31 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/zpa-test.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
with:
max_attempts: 3
timeout_minutes: 30
command: poetry run make test:integration:zpa
command: poetry run ansible-playbook tests/integration/run_all_tests.yml
env:
ZPA_CLIENT_ID: ${{ secrets.ZPA_CLIENT_ID }}
ZPA_CLIENT_SECRET: ${{ secrets.ZPA_CLIENT_SECRET }}
Expand Down Expand Up @@ -93,7 +93,7 @@ jobs:
with:
max_attempts: 3
timeout_minutes: 30
command: poetry run make test:integration:zpa
command: poetry run ansible-playbook tests/integration/run_all_tests.yml
env:
ZPA_CLIENT_ID: ${{ secrets.ZPA_CLIENT_ID }}
ZPA_CLIENT_SECRET: ${{ secrets.ZPA_CLIENT_SECRET }}
Expand Down Expand Up @@ -139,7 +139,7 @@ jobs:
with:
max_attempts: 3
timeout_minutes: 30
command: poetry run make test:integration:zpa
command: poetry run ansible-playbook tests/integration/run_all_tests.yml
env:
ZPA_CLIENT_ID: ${{ secrets.ZPA_CLIENT_ID }}
ZPA_CLIENT_SECRET: ${{ secrets.ZPA_CLIENT_SECRET }}
Expand Down
6 changes: 0 additions & 6 deletions tests/integration/targets/zpa_policy_access_app_protection_rule/tasks/main.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -84,19 +84,16 @@
operator: "{{ operator }}"
conditions:
- operator: "AND"
negated: false
operands:
- object_type: "PLATFORM"
lhs: ios
rhs: "true"
- operator: "AND"
negated: false
operands:
- object_type: "POSTURE"
lhs: "{{ posture_udid }}"
rhs: "false"
- operator: "AND"
negated: false
operands:
- object_type: "TRUSTED_NETWORK"
lhs: "{{ network_id }}"
Expand All @@ -123,19 +120,16 @@
operator: "{{ operator }}"
conditions:
- operator: "AND"
negated: false
operands:
- object_type: "PLATFORM"
lhs: ios
rhs: "true"
- operator: "AND"
negated: false
operands:
- object_type: "POSTURE"
lhs: "{{ posture_udid }}"
rhs: "false"
- operator: "AND"
negated: false
operands:
- object_type: "TRUSTED_NETWORK"
lhs: "{{ network_id }}"
Expand Down
6 changes: 0 additions & 6 deletions tests/integration/targets/zpa_policy_access_forwarding_rule/tasks/main.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -80,19 +80,16 @@
operator: "{{ operator }}"
conditions:
- operator: "{{ operator }}"
negated: false
operands:
- object_type: "PLATFORM"
lhs: ios
rhs: "true"
- operator: "{{ operator }}"
negated: false
operands:
- object_type: "POSTURE"
lhs: "{{ posture_udid }}"
rhs: "false"
- operator: "{{ operator }}"
negated: false
operands:
- object_type: "TRUSTED_NETWORK"
lhs: "{{ network_id }}"
Expand All @@ -118,19 +115,16 @@
operator: "{{ operator }}"
conditions:
- operator: "{{ operator }}"
negated: false
operands:
- object_type: "PLATFORM"
lhs: ios
rhs: "true"
- operator: "{{ operator }}"
negated: false
operands:
- object_type: "POSTURE"
lhs: "{{ posture_udid }}"
rhs: "false"
- operator: "{{ operator }}"
negated: false
operands:
- object_type: "TRUSTED_NETWORK"
lhs: "{{ network_id }}"
Expand Down
4 changes: 0 additions & 4 deletions tests/integration/targets/zpa_policy_access_isolation_rule/tasks/main.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,11 @@
operator: "{{ operator }}"
conditions:
- operator: "OR"
negated: false
operands:
- object_type: "CLIENT_TYPE"
lhs: "id"
rhs: "zpn_client_type_exporter"
- operator: "{{ operator }}"
negated: false
operands:
- object_type: "PLATFORM"
lhs: ios
Expand All @@ -111,13 +109,11 @@
operator: "{{ operator }}"
conditions:
- operator: "OR"
negated: false
operands:
- object_type: "CLIENT_TYPE"
lhs: "id"
rhs: "zpn_client_type_exporter"
- operator: "{{ operator }}"
negated: false
operands:
- object_type: "PLATFORM"
lhs: ios
Expand Down
8 changes: 0 additions & 8 deletions tests/integration/targets/zpa_policy_access_rule/tasks/main.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -97,25 +97,21 @@
- "{{ server_group_id }}"
conditions:
- operator: "AND"
negated: false
operands:
- object_type: "COUNTRY_CODE"
lhs: CA
rhs: "true"
- operator: "AND"
negated: false
operands:
- object_type: "PLATFORM"
lhs: ios
rhs: "true"
- operator: "AND"
negated: false
operands:
- object_type: "POSTURE"
lhs: "{{ posture_udid }}"
rhs: "false"
- operator: "AND"
negated: false
operands:
- object_type: "TRUSTED_NETWORK"
lhs: "{{ network_id }}"
Expand Down Expand Up @@ -146,25 +142,21 @@
- "{{ server_group_id }}"
conditions:
- operator: "{{ operator }}"
negated: false
operands:
- object_type: "COUNTRY_CODE"
lhs: CA
rhs: "true"
- operator: "{{ operator }}"
negated: false
operands:
- object_type: "PLATFORM"
lhs: ios
rhs: "true"
- operator: "{{ operator }}"
negated: false
operands:
- object_type: "POSTURE"
lhs: "{{ posture_udid }}"
rhs: "false"
- operator: "{{ operator }}"
negated: false
operands:
- object_type: "TRUSTED_NETWORK"
lhs: "{{ network_id }}"
Expand Down
4 changes: 0 additions & 4 deletions tests/integration/targets/zpa_policy_access_timeout_rule/tasks/main.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,11 @@
operator: "{{ operator }}"
conditions:
- operator: "{{ operator }}"
negated: false
operands:
- object_type: "PLATFORM"
lhs: ios
rhs: "true"
- operator: "{{ operator }}"
negated: false
operands:
- object_type: "POSTURE"
lhs: "{{ posture_udid }}"
Expand All @@ -111,13 +109,11 @@
operator: "{{ operator }}"
conditions:
- operator: "{{ operator }}"
negated: false
operands:
- object_type: "PLATFORM"
lhs: ios
rhs: "true"
- operator: "{{ operator }}"
negated: false
operands:
- object_type: "POSTURE"
lhs: "{{ posture_udid }}"
Expand Down

0 comments on commit 0dcca50

Please sign in to comment.