ATTENTION. Oversight on recent changes. #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently added codes has uninitialized value that isn't set here in Line: 3048, channel and reliableWindow. Not knowing exactly how to fix it myself I copied from line: 3006-7 that acquire the data for both variable. Perhaps this is why we should always initialize to 0 and null at the start?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently added codes #62 has uninitialized value that isn't set here in Line: 3048, channel and reliableWindow.
Not knowing exactly how it should be fixed. I copied from line: 3006-7 that acquire the data for both variable.
From what I can tell, it look like it would not even function should it ever be used without it.
Perhaps this is why we should always initialize to 0 and null at the start?
I just want to bring this to attention.