Test against node 18 and node 20 #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ci to test on node 18 in addition to 16.
Keep language more similar
|
We don't need to test on 16, which is EOL: https://nodejs.org/en/about/previous-releases And we definitely want to test on 20, which is LTS. If GitHub Actions supports 21, we should probably test on that too. We could also test on 18 on the grounds that it's still under maintenance. |
Remove testing against 16, add testing against node 20.
|
Thanks! |
avsm
pushed a commit
to avsm/translation-server
that referenced
this pull request
Apr 17, 2024
avsm
pushed a commit
to avsm/translation-server
that referenced
this pull request
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer test against 16 as it's EOL, test against both 18 and 20.