-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved installer #742
base: main
Are you sure you want to change the base?
Improved installer #742
Conversation
Impressive amount of changes! This will take me a few days to review! |
With a minor edit to the last line w.r.t issues closed, we can make GH auto-close them on the merge of this PR. |
My choice of words was deliberate to ensure this didn't happen ;-) As there is a lot of churn and some of the issues are subjective, explicitly checking those issues to see if the submitter is happy with the update is advised. |
Investigating test harness failures... |
Impressive |
I cloned this branch and ran zopen init on my existing file system and got this? Are we able to get it to work with existing file systems?
|
On a new zopen file system:
I have z/OS Open Tools find in my PATH |
I had tested migrating from 0.8.0 and 0.8.2 - but that was using the --refresh rather than re-init options... let me check that migration path
Another thing to investigate... |
@IgorTodorovskiIBM I've pushed a further commit that should resolve the issue when running in a new environment (ie. zopen init). slight issue is that when using the checked out version, it will automatically update meta to the latest in the repo so you then have to reapply the clone into the zopen filesystem. No easy way around that as copying the installing meta into the zopen filesystem could leave the system with an older meta than in the repo going forward, depengind on how quickly a packaged release is made available [if that makes sense]. |
If anyone has a chance [and is feeling up for a challenge!], the new installer for zopen is available for testing. The updated zopen will generate metadata when first "upgraded" so this needs more than just copying the files across - there needs to be a refresh.
|
|
2a04431
to
a1fd282
Compare
a1fd282
to
25cf670
Compare
6244713
to
6d8b9fe
Compare
Generate package install database if not present Enable autocacheclean capability (to clear downloaded paxes by default) Enable scriptlets for pre/post actions (man + cleanup) Remove custom filesystem layouts and RM_FILEPROCs Resolve some shellcheck issues
Update installation tracker db
Add delay after progress handler to stop screen overlays
Utilize package installation db and jq to massively speed up processing Uses new jqfunctions() function to "import" additional standard functions into jq queries
Move bulk of pax handling logic into common.sh Add detection of "local" pax file to install from file rather than repo
separation of concerns
add animations
local pax file handling QOL message improvements
@IgorTodorovskiIBM One of the new commits should resolve your issue with relative local paxes. |
To test the PR, replace with fq-path to zopen.test and all instances of zopen.test with test directory> :
|
@DevonianTeuchter I would like to test your new installer, but my employer's z/OS system has NO access to github or any other outside network locations and I do not have any copy of git available even if this system did have access to any network locations. If I |
Update to the installer primarily to handle install direct from file but includes:
-- auto-cache-clean - clean package cache after installation transaction completes [enabled by default]
-- man-db - run man-db automagically after install/alt/remove transactions [enabled if man-db package is installed]
-- caveats - display any "caveats" that a package might have after installation [a caveat being something an end user has to either run, configure or be aware of when using a certain package]
Should resolve/improve: #733 #717 #701 #694 #688 #675 #673 #661 #643 #633 #619 #617 #605 #567 #566 #558 #533 #472 #431 #381 #339 #240