Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate the basic sessioning with Products.Sessions #989

Merged
merged 4 commits into from
Oct 14, 2021

Conversation

dataflake
Copy link
Member

Fixes #985

Mostly documentation change: Update the Zope Book chapter on sessions to explain how to set up basic sessioning with Products.Sessions and to no longer discourage its use for small setups.

@dataflake dataflake requested review from icemac and pbauer October 12, 2021 16:21
@dataflake dataflake self-assigned this Oct 12, 2021
@dataflake
Copy link
Member Author

The test failures are unrelated, btw

Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from scanning through the changes.

Thank you for updating the documentation.

@icemac
Copy link
Member

icemac commented Oct 14, 2021

These flaky performance tests are really annoying.

@dataflake
Copy link
Member Author

These flaky performance tests are really annoying.

This seems to have gotten worse over the last weeks, maybe the GHA infrastructure is slowing down due to increased demand. IMHO running performance tests for an add-on package as part of the general Zope unit tests makes no sense.

@dataflake dataflake merged commit a7c1a92 into master Oct 14, 2021
@dataflake dataflake deleted the dataflake/reinstate_tempstorage branch October 14, 2021 07:01
dataflake added a commit that referenced this pull request Oct 14, 2021
* - reinstate the basic sessioning with Products.Sessions

* - both Products.Sessions and Products.TemporaryFolder must be installed [ci skip]

* - make sure Python versions are consistent

* - remove Python version pin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reinstate tempstorage
2 participants