-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
field2* converters should not handle files #963
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I general I like the idea, i just have some questions resp. suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think we need deprecation warnings in Zope 5: Zope 5 is Python 3 only and the file case is wrongly handled by the converters; thus, any user should already have been warned.
From my point of view, deprecation warnings are also not necessary in Zope 4: I assume that the "convert file" case is very rarely used.
Until now field converters could be applied on files with unclear outcome.
The problems with trying to convert files to text (detect MIME type, guess charset...)
were discussed in length in #558 (comment).
Handling files only makes sense for the
field2bytes
converter.This fixes #558