Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow switching to full form in "manage_access" #1039

Merged
merged 6 commits into from
May 11, 2022

Conversation

jan-jockusch
Copy link
Contributor

When the number of roles raises above 30, the form "manage_access" switches to a compact mode with no way of getting the full matrix view back.

While all functionality is still available, the compact form does not offer a full overview of permission settings.

Therefore, I believe an option to switch back to the full matrix view would be more user-friendly.

This PR provides this by adding a hyperlink with a request variable set to force the full permission matrix form even with more than 30 roles.

The behavior snaps back to normal on each click. The setting is not stored in the client or the session.

@icemac
Copy link
Member

icemac commented May 11, 2022

@jan-jockusch Thank you for the PR. Could you please share a screenshot? I currently have no project at hand with so many roles.

@jan-jockusch
Copy link
Contributor Author

Here are two shots of a form using this.

The first highlights the new hyperlink, the second one is just the standard form, as rendered with the new request option.

2022-05-11_09-30-shortened-form

2022-05-11_09-31-full-matrix

@icemac
Copy link
Member

icemac commented May 11, 2022

@jan-jockusch This looks nice. Could you please add an entry in the change log to make it perfect?

@icemac icemac self-requested a review May 11, 2022 11:25
@jan-jockusch
Copy link
Contributor Author

Thanks for reviewing this! Changelog entry added.

Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@icemac icemac merged commit 6c0333d into zopefoundation:master May 11, 2022
@jan-jockusch
Copy link
Contributor Author

Thanks!

@jan-jockusch jan-jockusch deleted the allow-switching-to-full-form branch May 12, 2022 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants