Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Export/)Import broken for "OFS.SimpleItem.Item_w__name__" instances #903

Closed
d-maurer opened this issue Oct 6, 2020 · 3 comments
Closed

(Export/)Import broken for "OFS.SimpleItem.Item_w__name__" instances #903

d-maurer opened this issue Oct 6, 2020 · 3 comments

Comments

@d-maurer
Copy link
Contributor

d-maurer commented Oct 6, 2020

BUG/PROBLEM REPORT

If an instance of OFS.SimpleItem.Item_w__name__ (e.g. an OFS.Image.File instance) is exported, a subsequent import fails with BadRequest: ('Empty or invalid id specified', '').

The reason: for Item_w__name__ instances, id must not be used (it is always ''); for those instances getId() must be used to access the object's id.
OFS.ObjectManager.ObjectManager._importObjectFromFile violates this restriction.

What version of Python and Zope/Addons I am using:

current Zope 4.x (likely Zope 5.x as well)
d-maurer added a commit that referenced this issue Oct 6, 2020
@d-maurer
override id in OFS.SimpleItem.Item_w__name__ to avoid bugs by use…
d1cac90 
… of deprecated direct `id` access (--> #903)
This was referenced Oct 6, 2020
Merged
Merged
d-maurer added a commit that referenced this issue Oct 7, 2020
@d-maurer
override id in OFS.SimpleItem.Item_w__name__ to avoid bugs by use…
80dfab9 
… of deprecated direct `id` access (--> #903) (#906)
dataflake added a commit that referenced this issue Oct 8, 2020
@dataflake
override id in OFS.SimpleItem.Item_w__name__ to avoid bugs by use…
bea75e6 
… of deprecated direct `id` access (--> #903) (#906)
@dataflake
Copy link
Member

dataflake commented Oct 8, 2020 •
edited
Loading

@d-maurer I have handled the forward port to master so it gets into Zope 5. See bea75e6

@d-maurer
Copy link
Contributor Author

d-maurer commented Oct 8, 2020 via email

@dataflake
Copy link
Member

Both #906 and #907 are merged so I'll close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dataflake @d-maurer