Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authentication error viewing ZMI with a user defined outside of zope root #1195

Closed
perrinjerome opened this issue Feb 17, 2024 · 0 comments · Fixed by #1196
Closed

Authentication error viewing ZMI with a user defined outside of zope root #1195

perrinjerome opened this issue Feb 17, 2024 · 0 comments · Fixed by #1196

Comments

@perrinjerome
Copy link
Contributor

BUG/PROBLEM REPORT / FEATURE REQUEST

manage_page_header makes a head like this:

<!doctype html>
<html lang="en">
<head>

<meta http-equiv="content-type" content="text/html;charset=utf-8" />

<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no" />

<title>Zope</title>

	<link rel="stylesheet" type="text/css" href="/++resource++zmi/bootstrap-4.6.0/bootstrap.min.css" />
	<link rel="stylesheet" type="text/css" href="/++resource++zmi/fontawesome-free-5.15.2/css/all.css" />
	<link rel="stylesheet" type="text/css" href="/++resource++zmi/zmi_base.css" />
	<script src="/++resource++zmi/jquery-3.5.1.min.js"></script>
	<script src="/++resource++zmi/bootstrap-4.6.0/bootstrap.bundle.min.js"></script>
	<script src="/++resource++zmi/ace.ajax.org/ace.js"></script>
	<script src="/++resource++zmi/zmi_base.js"></script>

Since the "Restrict access to static ZMI resources." changes from ce5288a (Update ACE editor 1.4.4 to 1.5.0 (#1166), 2023-10-11), the links for zmi require view management screens permission.

Because the link is like this:

	<script src="/++resource++zmi/jquery-3.5.1.min.js"></script>

in practice they require view management screens permissions at the root of zope.

What I did:

  1. create a folder subfolder
  2. create a user folder in that folder
  3. create a user u with manager role in /subfolder/acl_users
  4. login as u and visit /subfolder/manage_main

What I expect to happen:

view management screens

What actually happened:

401 error while getting CSS and javascripts

What version of Python and Zope/Addons I am using:

this started from 5.9 and is still the case on current master.

I'll send a pull request, I think we can change the links generation logic to include the authentication path from the user. In the example case the link would be:

	<script src="/subfolder/++resource++zmi/jquery-3.5.1.min.js"></script>
perrinjerome added a commit to perrinjerome/Zope that referenced this issue Feb 17, 2024
@perrinjerome
Fix authentication error viewing ZMI with a user defined outside of z…
9eb54ae 
…ope root.

Fixes zopefoundation#1195
@perrinjerome perrinjerome mentioned this issue Feb 17, 2024
Merged
perrinjerome added a commit to perrinjerome/Zope that referenced this issue Feb 17, 2024
@perrinjerome
Fix authentication error viewing ZMI with a user defined outside of z…
c8c52a1 
…ope root.

Fixes zopefoundation#1195
perrinjerome added a commit that referenced this issue Feb 27, 2024
@perrinjerome @icemac
Fix authentication error viewing ZMI with a user defined outside of z…
7f6a4d1 
…ope root. (#1196)

Fixes #1195

Co-authored-by: Michael Howitz <icemac@gmx.net>
@mauritsvanrees mauritsvanrees mentioned this issue Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix authentication error viewing ZMI with a user defined outside of zope root perrinjerome/Zope
1 participant
@perrinjerome