Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): missing hasConstants boolean on ReactModuleInfo #63

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

huextrat
Copy link
Contributor

@huextrat huextrat commented Jan 9, 2025

Summary

Android is not building from 1.3.0

Error :

None of the following functions can be called with the arguments supplied:
public constructor ReactModuleInfo(_name: String, _className: String, _canOverrideExistingModule: Boolean, _needsEagerInit: Boolean, isCxxModule: Boolean, isTurboModule: Boolean)

Test Plan

What's required for testing (prerequisites)?

What are the steps to test it (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I added a sample use of the API in the example project (example/src/App.tsx)

@huextrat huextrat requested a review from zoontek as a code owner January 9, 2025 14:27
@zoontek
Copy link
Owner

zoontek commented Jan 9, 2025

@huextrat which react native version are you using? Latest version should be compatible with 0.74, according to react-native releases, and the new method signature was available in 0.74.

@zakharchenkoAndrii
Copy link

I am currently updating to expo 52 + "react-native": "0.76.5", and getting the same error

@zoontek zoontek merged commit 18a8a47 into zoontek:main Jan 9, 2025
@zoontek
Copy link
Owner

zoontek commented Jan 9, 2025

@zakharchenkoAndrii weird, no issue with bare react-native on my side. Shipping this, just in case.

@zoontek
Copy link
Owner

zoontek commented Jan 9, 2025

@huextrat @zakharchenkoAndrii Done, I will investigate later: https://github.com/zoontek/react-native-edge-to-edge/releases/tag/1.3.1

@huextrat
Copy link
Contributor Author

huextrat commented Jan 9, 2025

Bare RN on 0.76.5 and 0.76.6

Yes, it's surprising because we should have both constructors on the Android side

@zoontek
Copy link
Owner

zoontek commented Jan 9, 2025

Anyway, thanks for the quick PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants