Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google's timeline to the README around the targetSdkVersion enforcement #31

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

fabiendem
Copy link
Contributor

Summary

Clarify the calendar around the requirements for the Android targetSdkVersion bump.
Google now always follows the same cadence for the requirements around the targetSdkVersion bump on the Google Play Store: the next version is required on August 31st, the year after the SDK update's release, if you want to ship a new app, or if you want to keep shipping updates for an existing app.

See https://support.google.com/googleplay/android-developer/answer/11926878?sjid=11853000253346477363-EU#zippy=%2Care-there-any-exceptions-for-existing-apps-targeting-api-or-below

So we can expect the targetSdkVersion: 35 to be enforced on August 31st 2025.

I also rephrased

Currently, the latest version of React Native targets SDK 34, so this isn't an issue yet, but it will be in a future release.

to

Currently, the latest version of React Native targets the Android SDK 34.

The original sentence suggests that if React Native targets the SDK 35, your app must target the SDK 35 no matter what. But even if React Native targets the SDK 35, you can always force your app to keep targeting the SDK 34 until August 31st 2025. Ultimately, you maintain control of this parameter until the deadline.
This is different than the minSdkVersion.

Test Plan

This is a README change.
It renders as expected and has no typos.

What's required for testing (prerequisites)?

  • Proofread
  • Understand Google's calendar

What are the steps to test it (after prerequisites)?

N/A

Compatibility

N/A

OS Implemented
iOS
Android

Checklist

  • [] I have tested this on a device and a simulator - N/A
  • I added the documentation in README.md
  • [] I added a sample use of the API in the example project (example/src/App.tsx) - N/A

@fabiendem fabiendem marked this pull request as ready for review October 14, 2024 11:50
@fabiendem fabiendem requested a review from zoontek as a code owner October 14, 2024 11:50
@zoontek
Copy link
Owner

zoontek commented Oct 14, 2024

@fabiendem Thanks for this, you are right about apps targetting SDK 34. I commited a few changes, WDYT?

Copy link
Contributor Author

@fabiendem fabiendem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @zoontek. Thanks for everything!

@zoontek zoontek merged commit 2ed3e52 into zoontek:main Oct 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants