-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monkey patch iris and speed up crunching #72
Conversation
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 97.63% 98.29% +0.65%
==========================================
Files 10 10
Lines 1184 1287 +103
Branches 165 184 +19
==========================================
+ Hits 1156 1265 +109
+ Misses 18 16 -2
+ Partials 10 6 -4
Continue to review full report at Codecov.
|
Twice the monkey @rgieseke :) |
182d3ea
to
c74582c
Compare
@rgieseke I found the issues in iris which illustrate this issue: SciTools/iris#3333 SciTools/iris#3357 |
Also step through iris collapsed and see that it will never call a lazy function if there are weights and hence that trying to optimise `take_lat_lon_mean` with dask is a waste of time.
54118b4
to
3ed2cd9
Compare
ba6dcf2
to
0b5fcb3
Compare
Pull request
Please confirm that this pull request has done the following:
CHANGELOG.rst
addedAdding to CHANGELOG.rst
Please add a single line in the changelog notes similar to one of the following:
Supercedes #68