zig_test test_runner should accept a zig_library
#2
Comments
gwenzek
added a commit
to zml/zml
that referenced
this issue
Oct 9, 2024
The end goal is to allow zml users to use our async test runner in their project. This approach works but is a bit hacky because it relies on the fact that `test_runner.zig` is part of the `zml` library otherwise `zig_test` doesn't correctly put the test_runner into the build sandbox. I made this dependency explicit, but it was already the case because of the glob pattern used in zml library. And I think `test_runner` should be `zig_library` in the first place, and not a filegroup. See zml/rules_zig#2 for follow up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The end goal is to allow zml users to use our async test runner in their project.
Currently
test_runneraccept a file, but the file is not pulled into the build sandbox.Also a
test_runner.zigmay have dependencies (asyncin our case) so accepting a file is semantically incorrect.The current workaround consist of declaring
test_runner.zighas part of thezmllib ensuring that it is always present in the build sandbox, but it should only appear on when building the test target.The text was updated successfully, but these errors were encountered: