Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nrfmicro_13_52833 support #912

Merged
merged 5 commits into from
Oct 3, 2022
Merged

Conversation

pashutk
Copy link
Contributor

@pashutk pashutk commented Aug 15, 2021

This PR adds support for E73-2G4M08S1E (nrf52833-based module from EBYTE) to use with nrfmicro 1.3+ board instead of E73-2G4M08S1C.

Since E73-2G4M08S1E is cheaper and more or less available on the aliexpress for reasonable price, 52833-based nrfmicro could be seen as affordable alternative to 52840-based nrfmicro. Also for a wireless split builds there is no need to have 1mb flash memory and 512kb is enough in most cases.

IMG_6500

Nrfnicro boards with 2G4M08S1E module has been battle-tested on several builds (fifi, helix, skeletyl) by myself and I'm aware of at least several boards built by @krikun98. I hope he will also provide more details on how 1.11 pin now works.

@petejohanson petejohanson added enhancement New feature or request shields PRs and issues related to shields board PRs and issues related to boards. and removed shields PRs and issues related to shields labels Sep 25, 2021
@pashutk pashutk force-pushed the nrf52833 branch 4 times, most recently from fd10492 to 983e408 Compare January 14, 2022 11:44
@pashutk pashutk marked this pull request as ready for review January 17, 2022 12:26
@krikun98
Copy link
Contributor

833_screen
I've built several boards with this firmware, both with nrfmicros and bare E73-2G4M08S1E modules. This is built for a softdevice-enabled bootloader, but there's still enough memory left for screens (as depicted) and RGB (haven't tested that, but the firmware builds). I've also built nrfmicros for direct-pin boards (Sweep), so I'm reasonably sure every pin works.

@krikun98
Copy link
Contributor

krikun98 commented Jan 17, 2022

The only thing that's somewhat weird is that the bootloader LED does not seem to blink at startup, only on resets/wakeups, but that's bootloader-related.

@krikun98
Copy link
Contributor

The Pro Micro pin D10 has been reassigned to 1.04, a previously unused pin accessible from the back, as 1.11 is not present on the 2G4M08S1E. Joric's current 1.4.x revision includes a jumper, and existing boards may be modified with an unobtrusive bodge wire, although this isn't necessary for many shields.
P_20220117_185922

@pashutk
Copy link
Contributor Author

pashutk commented Jan 17, 2022

The Pro Micro pin D10 has been reassigned to 1.04, a previously unused pin accessible from the back, as 1.11 is not present on the 2G4M08S1E. Joric's current 1.4.x revision includes a jumper, and existing boards may be modified with an unobtrusive bodge wire, although this isn't necessary for many shields.

P_20220117_185922

Can you post the link to 1.4.X revision here please?

@krikun98
Copy link
Contributor

Can you post the link to 1.4.X revision here please?

It's his main branch now: https://github.com/joric/nrfmicro/

, <7 0 &gpio0 24 0> /* D6/A7 */
, <8 0 &gpio0 10 0> /* D8/A8 */
, <9 0 &gpio1 6 0> /* D9/A9 */
, <10 0 &gpio1 11 0> /* D10/A10 */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analog pin should also be changed to <10 0 &gpio1 4 0>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One catch on the metadata file.

app/boards/arm/nrfmicro/nrfmicro_13_52833.zmk.yml Outdated Show resolved Hide resolved
Co-authored-by: Pete Johanson <peter@peterjohanson.com>
@petejohanson
Copy link
Contributor

Can you please rebase on latest main and force push? Docs deploy failing, probably from missing some fixes there. Thanks!

@pashutk pashutk force-pushed the nrf52833 branch 2 times, most recently from d98e9b5 to 20cb904 Compare October 2, 2022 16:34
@pashutk pashutk requested a review from petejohanson October 2, 2022 16:38
@pashutk
Copy link
Contributor Author

pashutk commented Oct 2, 2022

Can you please rebase on latest main and force push? Docs deploy failing, probably from missing some fixes there. Thanks!

Screwed up commit's dates at first but now the history seems fine and it builds

Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@petejohanson petejohanson merged commit 1e25ee7 into zmkfirmware:main Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
board PRs and issues related to boards. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants