Add dynamic diagnostic

[gavrilikhin-d]

Draft for dynamic diagnostics for design discussion.

Implements #259

[gavrilikhin-d]

Do you agree with DynamicDiagnostic name?

[gavrilikhin-d]

How generic should this class be?

I tried using generic types with defaults:

struct DynamicDiagnostic<D = String, C = String, ...> 
where
    D: Debug + Display,
    C: Debug + Display,
    ...
{
   pub description: D,
   pub code: Option<C>,
   ...
}

But this was ambiguous if using None values:

let diag: DynamicDiagnostic<&str, String, ...> = DynamicDiagnostic {
   description: "",
   code: None,
   ...
};

[zkat]

Looks good so far! I don't think this needs to be generic, tbh

[zkat]

This is looking really great so much! Thanks for taking this on! Just a couple more comments and I think we're good to merge?

[gavrilikhin-d]

is cargo readme from #124 not longer working?

[zkat]

is cargo readme from #124 not longer working?

@gavrilikhin-d cargo make readme

[zkat]

I think we're good now! I know this was a lot of back and forth but I think we got somewhere very nice. Thanks so much for your time and effort!!

[zkat]

looks like you have a clippy thing too

[gavrilikhin-d]

Issues #259 and #201 will be resolved by this pr

[gavrilikhin-d]

Why tests fail on windows? Looks like it can't find local arguments and assumes they are named arguments

[zkat]

I think 1.56.0 is before format argument interpolation was stabilized, now that I think about it

[gavrilikhin-d]

@zkat how can I fix it? See no way to conditionally compile code depending on rust version.

My best guess is to introduce new default feature format_args_capture

[gavrilikhin-d]

Now it will pass workflow (checked in my fork)

[zkat]

Yay! It's in!!