This repository was archived by the owner on Jul 3, 2019. It is now read-only.
fix(index): additional bucket entry verification with checksum #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cacache was just using
length
for these entries before. As I thought more about consistency checks and verification, I wondered if it was worth the cost to just straight-up hashing that entry string. Turns out the cost was minimal, and I think this brings entry verification into the "tremendous confidence in consistency" realm, which feels like a warm-fuzzy guarantee to be able to make.Benchmarks