Adds support macOS dylib #86
Conversation
|
Hi @eric please check my changes. I found some issue to compile on macOS Mojave beta: somehow |
ext/extconf.rb
Outdated
| @@ -83,10 +83,9 @@ def safe_sh(cmd) | |||
|
|
|||
| # Absolutely prevent the linker from picking up any other zookeeper_mt | |||
| Dir.chdir("#{HERE}/lib") do | |||
| %w[st mt].each do |stmt| | |||
There was a problem hiding this comment.
Why remove the line copying the mt version?
There was a problem hiding this comment.
based on https://github.com/zk-ruby/zookeeper/pull/86/files#diff-b3c266c0a40fd6ea5ce51093b147dbe6R93 there is no mt usage. I could split into 2 commits with dylib adding and then with small refactoring
There was a problem hiding this comment.
I think, yep I'll create separate PR for that refactoring
There was a problem hiding this comment.
Updated PR without this change
Clang-7 linker does not support `.a` and `.la` libs. Use dylibs for linker instead of old libraries
|
Hi @eric please check again. I removed extra cleanups. Just added support for |
|
Looks good |
No description provided.