Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zk-issue-47 #48

Merged
merged 1 commit into from
Jul 10, 2013
Merged

zk-issue-47 #48

merged 1 commit into from
Jul 10, 2013

Conversation

jaeho-kim
Copy link
Contributor

change permission constants (same with zookeeper native perm number and use bit shifting)

@eric
Copy link
Member

eric commented Jul 10, 2013

I'm trying to figure out a reason not to use the bit shifting that is done in the other code that was referenced in #47.

@slyphon: Can you think of a reason not to do this?

        ZOO_PERM_READ = 1 << 0
        ZOO_PERM_WRITE = 1 << 1
        ZOO_PERM_CREATE = 1 << 2
        ZOO_PERM_DELETE = 1 << 3
        ZOO_PERM_ADMIN = 1 << 4

@jaeho-kim
Copy link
Contributor Author

I just follow previous coding pattern. I think use bit shifting is better than before

@slyphon
Copy link
Contributor

slyphon commented Jul 10, 2013

LGTM

eric added a commit that referenced this pull request Jul 10, 2013
Fix ACL constants to make permissions work as expected
@eric eric merged commit 369af5a into zk-ruby:master Jul 10, 2013
@eric
Copy link
Member

eric commented Jul 10, 2013

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants