Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add support for loadbalancing with any resource attribute #1

Closed
wants to merge 11 commits into from
Closed

[WIP] Add support for loadbalancing with any resource attribute #1

wants to merge 11 commits into from

Conversation

zjanc
Copy link
Owner

@zjanc zjanc commented Feb 14, 2023 •
edited
Loading

[WIP] Add support for loadbalancing with any resource attribute

Changes

To-do

  • Test coverage
  • Update README

@zjanc zjanc changed the title Add support for loadbalancing with any resource attribute [WIP] Add support for loadbalancing with any resource attribute Feb 14, 2023
@zjanc zjanc changed the base branch from main to canva-main February 16, 2023 13:21
@zjanc zjanc force-pushed the zjan-add-arbitrary-attr-support-loadbalancing branch from 141ae13 to 1adac91 Compare February 16, 2023 13:21
@zjanc zjanc force-pushed the zjan-add-arbitrary-attr-support-loadbalancing branch from 1adac91 to c3a8230 Compare February 17, 2023 01:39
foadnh
foadnh approved these changes Feb 17, 2023
View reviewed changes
Copy link

@foadnh foadnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few comments

exporter/loadbalancingexporter/config.go Outdated Show resolved Hide resolved
exporter/loadbalancingexporter/trace_exporter.go Outdated Show resolved Hide resolved
exporter/loadbalancingexporter/trace_exporter.go Outdated Show resolved Hide resolved
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Mar 10, 2023
@github-actions github-actions bot removed the Stale label Mar 16, 2023
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Mar 31, 2023
@github-actions
Copy link

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foadnh foadnh foadnh approved these changes

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[loadbalancingexporter] Not properly batching service traces
2 participants
@zjanc @foadnh