feat: merge the verifier types #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: - The various verifier types are merged into a oidc.Verifir. - oidc.Verfier became a struct with exported fields
this binds the correct contstructor to each verifier usecase.
8ec8c33 to
d877539
Compare
462a108 to
7a49693
Compare
Codecov Report
@@ Coverage Diff @@
## next #336 +/- ##
==========================================
+ Coverage 50.84% 52.28% +1.43%
==========================================
Files 74 74
Lines 5631 5587 -44
==========================================
+ Hits 2863 2921 +58
+ Misses 2508 2414 -94
+ Partials 260 252 -8
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JWTTokenRequest.GetIssuedAt() was returning the ExpiresAt field. This change corrects that by returning IssuedAt instead. This bug was introduced in #283
muhlemmer
commented
Mar 21, 2023
There was a problem hiding this comment.
This file is used only for tests. Changes here are to accommodate newly added tests.
pkg/oidc/types.go
Outdated
There was a problem hiding this comment.
Changes cherry-picked from #339
| @@ -192,7 +192,7 @@ func (j *JWTTokenRequest) GetExpiration() time.Time { | |||
|
|
|||
| // GetIssuedAt implements the Claims interface | |||
| func (j *JWTTokenRequest) GetIssuedAt() time.Time { | |||
| return j.ExpiresAt.AsTime() | |||
| return j.IssuedAt.AsTime() | |||
There was a problem hiding this comment.
Cherry -pick from #341
4 tasks
stebenz
reviewed
Mar 22, 2023
stebenz
approved these changes
Mar 22, 2023
|
🎉 This PR is included in version 3.0.0-next.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Closes #314
TODO:
ValidateAuthReqIDTokenHint()