chore: document non-standard glob client #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #328 +/- ##
==========================================
+ Coverage 50.80% 50.97% +0.16%
==========================================
Files 74 74
Lines 5623 5648 +25
==========================================
+ Hits 2857 2879 +22
- Misses 2506 2508 +2
- Partials 260 261 +1
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@muhlemmer LGTM. Other auth servers also support globs. For example, Keycloak. |
rename checkURIAginstRedirects to checkURIAgainstRedirects
add example on how to toggle the underlying client implementation based on DevMode.
4a2424d to
82c1eef
Compare
muir
approved these changes
Mar 28, 2023
Co-authored-by: David Sharnoff <dsharnoff@singlestore.com>
stebenz
approved these changes
Mar 28, 2023
|
🎉 This PR is included in version 2.2.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.0.0-next.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the docs and example on glob support regarding standard deviation.
Glob pattern matching was introduced as an optional interface in #297 to provide wildcard support.
Open to discussion.
Closes #308