Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow RFC3339 encoded time strings #311

Merged
merged 1 commit into from
Mar 15, 2023
Merged

fix: allow RFC3339 encoded time strings #311

merged 1 commit into from
Mar 15, 2023

Conversation

muhlemmer
Copy link
Collaborator

@muhlemmer muhlemmer commented Mar 6, 2023 •
edited
Loading

Fixes #292

@codecov
Copy link

codecov bot commented Mar 6, 2023 •
edited
Loading

Codecov Report

Merging #311 (a3fe782) into next (dea8bc9) will increase coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             next     #311      +/-   ##
==========================================
+ Coverage   46.52%   46.72%   +0.20%     
==========================================
  Files          74       74              
  Lines        5567     5588      +21     
==========================================
+ Hits         2590     2611      +21     
  Misses       2748     2748              
  Partials      229      229
Impacted Files Coverage Δ
pkg/oidc/types.go 91.05% <100.00%> (+1.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@muhlemmer muhlemmer force-pushed the muhlemmer/issue292 branch from 7264a7c to 80dbc32 Compare March 10, 2023 14:38
@muhlemmer muhlemmer force-pushed the muhlemmer/issue292 branch from 80dbc32 to a3fe782 Compare March 10, 2023 14:40
@muhlemmer muhlemmer marked this pull request as ready for review March 10, 2023 14:41
@muhlemmer muhlemmer linked an issue Mar 10, 2023 that may be closed by this pull request
Parse Auth0 updated_at #292
Closed
@muhlemmer muhlemmer enabled auto-merge (rebase) March 10, 2023 15:01
@muhlemmer muhlemmer added this to the v2 milestone Mar 13, 2023
@muhlemmer muhlemmer merged commit 711a194 into next Mar 15, 2023
@muhlemmer muhlemmer deleted the muhlemmer/issue292 branch March 15, 2023 13:18
@github-actions
Copy link

🎉 This PR is included in version 2.0.0-next.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@monstermunchkin
Copy link
Contributor

@muhlemmer

Will this fix be backported to v1? Or is v1 no longer maintained?

@muhlemmer
Copy link
Collaborator Author

The Time type on v1 is fundamentally different, so this fix is not compatible / back-portable to v1. There is was no official intention from our side to maintain v1, as v2 was already in beta for over a year. I will discuss with the team if we could open a v1 support branch.

@muhlemmer
Copy link
Collaborator Author

See: #342 on v1 support

@muhlemmer muhlemmer mentioned this pull request Mar 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stebenz stebenz stebenz approved these changes

@muir muir muir approved these changes

Assignees
No one assigned
Labels
released on @next released
Projects
None yet
Milestone
v2
Development

Successfully merging this pull request may close these issues.

Parse Auth0 updated_at
4 participants
@muhlemmer @monstermunchkin @muir @stebenz