Use a single FiberRef for retrieving the Cache and identifying disabled caching
#495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostdogpr
previously approved these changes
Jul 2, 2024
# Conflicts: # benchmarks/src/main/scala/zio/query/FromRequestBenchmark.scala # zio-query/shared/src/main/scala/zio/query/ZQuery.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we use 2
FiberRefs in the hotpath; one for retrieving the cache and another to check whether caching is enabled. Since disabling the cache is not a standard usecase, we can use a single on to represent both (by having the cache FiberRef return a None when caching is disabled). So that we're able to re-enable caching without loss of the cached values, we store the cache in a secondaryFiberRefwhenever it's disabled. Since this is not a common operation, it's much more performant than previously