Magnolia derivation for Debug typeclass #1371
Conversation
1f2cb8b to
d9ae483
Compare
project/BuildHelper.scala
Outdated
| "com.softwaremill.magnolia1_3" %% "magnolia" % "1.3.7" | ||
| case _ => | ||
| "com.softwaremill.magnolia1_2" %% "magnolia" % "1.1.10" | ||
| // libraryDependencies += compilerPlugin("org.typelevel" %% "kind-projector" % "0.13.3" cross CrossVersion.full) |
| @@ -0,0 +1,38 @@ | |||
| package zio.debug.magnolia | |||
There was a problem hiding this comment.
The package name should be zio.prelude.magnolia.
There was a problem hiding this comment.
What do you think about adding an extension method on the Debug companion object, so that it also contains the derived method, so that in Scala 3 we can do case class Child(name: String, age: Int) derives Debug?
There was a problem hiding this comment.
Whhhhhaou that exactly what I did not knew how to do !
Thx, will do it tonight.
There was a problem hiding this comment.
Hum, I suppose then that I should merge magnolia and core module, right ?
Or AFAIU I run in cyclic dependencies.
There was a problem hiding this comment.
cyclic dependencies
Nope. Have zio-prelude-magnolia depend on zio-prelude. zio-prelude must not know about Magnolia or ``zio-prelude-magnolia`.
That's why we'll make it an extension method of the Debug companion object. Not an actual method on Debug companion object.
There was a problem hiding this comment.
:-/
Just pushed the simplest fix.
No idea how to add an extension to an existing companion object.
There was a problem hiding this comment.
Ok @sideeffffect I found :S
ci: 👌 @sideeffffect
|
You welcome.
Thanks for the review and tips.
I was not aware that extension could target a companion object.
Thx
Le jeu. 5 sept. 2024 à 21:52, Ondra Pelech ***@***.***> a
écrit :
… ***@***.**** approved this pull request.
Awesome, thank you so much again! 🎉
—
Reply to this email directly, view it on GitHub
<#1371 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC4NK7PJNUVLNV26SDBJBLZVCY67AVCNFSM6AAAAABNUYQPLCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEOBTHE2TQMBTHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
closes #1076