Hotfix transparent viewkey missing #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ignore the clippy here. its updated in dev but not worth hotfixing |
6ed461b to
bfb2239
Compare
juanky201271
reviewed
Mar 7, 2024
There was a problem hiding this comment.
My concern about this is:
- A user can restore from vk, and after that when the user wants to check the vk, the App shows up an error message?
Restore from ufvk&exportufvkwould have to be synchronize, right? both with an error message or not, something coherent.
…ewkey that came in
|
right o. the new version should export the transparentless viewkey |
|
addresses the panic on line 179 of unified.rs |
Oscar-Pepper
approved these changes
Mar 8, 2024
Thanks, I appreciated that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes test that covers